feat: add Subscription base class on app instance #3058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
估计之前没有人用 class 写过 schedule |
Codecov Report
@@ Coverage Diff @@
## master #3058 +/- ##
==========================================
+ Coverage 99.75% 99.75% +<.01%
==========================================
Files 29 29
Lines 829 830 +1
==========================================
+ Hits 827 828 +1
Misses 2 2
Continue to review full report at Codecov.
|
|
有的吧，都直接 require 的 |
atian25
reviewed
Sep 29, 2018
| 'use strict'; | ||
|
|
||
| module.exports = app => { | ||
| return class LoggerExample extends app.Subscription { |
There was a problem hiding this comment.
说个题外的，我倒是挺想加个 app.Schedule 的，而不是让定时任务直接继承基类 Subscription
不过插件里面好像没法挂。
There was a problem hiding this comment.
Schedule 就像 Controller 这样的基类。
Subscription 不是 Schedule 专用的。
应用层可以 require，但是插件只能通过 app 获取。 |
目前 class 的方式用起来有点别扭 |
dead-horse
approved these changes
Oct 8, 2018
popomore
pushed a commit
that referenced
this pull request
Oct 8, 2018
feat: add Subscription base class on app instance (#3058)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change